Improve the download ontology process #132
Merged
+41
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy on large ontology
matentzn
reviewed
Aug 21, 2024
There was a problem hiding this comment.
This looks good to me, but I assigned @jsstevenson for a more pythonic review, as my pythonic is rusty
jsstevenson
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how to download an ontology. It gets a more robust system.
Previously it just called a function from
urllib.requestto download the ontology and save it in a file.Now I created a function to stream the download and also retry download 3x in case of error, especially
ChunkedEncodingErrorwhich was the original issue.Fixes #130